[pallet-revive] Add host function to_account_id
#7091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmichi
changed the title
to_account_idto_account_id
athei
reviewed
Jan 8, 2025
athei
approved these changes
Jan 15, 2025
Comment on lines
565
to
568
| let caller = whitelisted_caller(); | ||
| let origin: T::RuntimeOrigin = RawOrigin::Signed(caller.clone()).into(); | ||
| Contracts::<T>::map_account(origin.clone()).unwrap(); | ||
| let address = T::AddressMapper::to_address(&caller); |
There was a problem hiding this comment.
Should also fix the type inference error (hopefully).
Suggested change
| let caller = whitelisted_caller(); | |
| let origin: T::RuntimeOrigin = RawOrigin::Signed(caller.clone()).into(); | |
| Contracts::<T>::map_account(origin.clone()).unwrap(); | |
| let address = T::AddressMapper::to_address(&caller); | |
| let address = { | |
| let caller = account("seal_to_account_id", 0, 0)); | |
| T::AddressMapper::map(&caller).unwrap(); | |
| T::AddressMapper::to_address(&caller) | |
| }; |
There was a problem hiding this comment.
Just applied your suggestion. I didn't get a type inference error locally though when running the benchmark, where did you see it?
There was a problem hiding this comment.
The CI failed with a compilation error.
xermicus
approved these changes
Jan 15, 2025
|
/cmd fmt |
|
Command "fmt" has started 🚀 See logs here |
|
Command "fmt" has failed ❌! See logs here |
|
Okay you have to run |
|
@athei I updated the PR. |
Merged
via the queue into
paritytech:master
with commit Jan 15, 2025
412aca6
193 of 204 checks passed
ordian
added a commit
that referenced
this pull request
Jan 16, 2025
* master: (33 commits) Implement `pallet-asset-rewards` (#3926) [pallet-revive] Add host function `to_account_id` (#7091) [pallet-revive] Remove revive events (#7164) [pallet-revive] Remove debug buffer (#7163) litep2p: Provide partial results to speedup GetRecord queries (#7099) [pallet-revive] Bump asset-hub westend spec version (#7176) Remove 0 as a special case in gas/storage meters (#6890) [pallet-revive] Fix `caller_is_root` return value (#7086) req-resp/litep2p: Reject inbound requests from banned peers (#7158) Add "run to block" tools (#7109) Fix reversed error message in DispatchInfo (#7170) approval-voting: Make importing of duplicate assignment idempotent (#6971) Parachains: Use relay chain slot for velocity measurement (#6825) PRDOC: Document `validate: false` (#7117) xcm: convert properly assets in xcmpayment apis (#7134) CI: Only format umbrella crate during umbrella check (#7139) approval-voting: Fix sending of assignments after restart (#6973) Retry approval on availability failure if the check is still needed (#6807) [pallet-revive-eth-rpc] persist eth transaction hash (#6836) litep2p: Sufix litep2p to the identify agent version for visibility (#7133) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6891.
cc @athei @xermicus @pgherveou